pipreqs icon indicating copy to clipboard operation
pipreqs copied to clipboard

Small change to make debugging file parse errors easier 2

Open abrahamw88 opened this issue 3 years ago • 2 comments

Now when ast.parse() encounters a file that cannot be parsed due to syntax errors it will report that filename in it's traceback.

abrahamw88 avatar Sep 16 '21 11:09 abrahamw88

Codecov Report

Merging #279 (2737448) into next (e7571ea) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #279   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files           2        2           
  Lines         256      256           
=======================================
  Hits          224      224           
  Misses         32       32           
Impacted Files Coverage Δ
pipreqs/pipreqs.py 87.35% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7571ea...2737448. Read the comment docs.

codecov-commenter avatar Sep 16 '21 16:09 codecov-commenter

hi @abrahamw88 thank you for the new pr! Are you familiar with git rebase? you could have done an interactive git rebase in your first PR in order to reword your commit. Another option would have been to use git commit --amend.

Could you use git rebase to drop all commits besides the one with the actual changes? I understand that I may be sounding annoying by asking again for changes but this is important to keep the project organized and maintainable. Also, when you write a commit message you should try to make the first line a simple and short (around 80 characters) description of what your commit does, then in the following lines you can enter into more details of what you did.

One last tip: You can use a force push to alter this PR, this way you wont need to open a third PR. Normally force pushing is seen as something bad but since this is your personal branch that nobody else is using there is no problem in using a force push.

alan-barzilay avatar Sep 20 '21 01:09 alan-barzilay