pipreqs
pipreqs copied to clipboard
Tests do not respect flake8
since we tested flake8 compliance with tox, the tests where never validated for flake8 violations
Hi @alan-barzilay ,
I'm new to open source, I want to take up this issue. This will be my first issue. May I?
Of course @kuldeepkhatke ! but just a heads up, I will be rebasing the "next" branch which may introduce some conflicts in your work. You said you were new to open source, do you know how to make a rebase and to resolve conflicts? If you dont you may want to wait a few days until I make the new pipreqs release and sort this all out
@alan-barzilay , I'm new to open source but have good knowledge of git commands :)
I'll handle the rebase & conflicts resolving part.
@kuldeepkhatke great! then just be warned that I will force push into the next branch. I need to make it inline with the master branch which has a revert commit to make it synchronized with the latest release. I will basically introduce the revert commit and then a revert of the revert.
(I know this is kinda dirty and that we should avoid force pushing but pipreqs needed some cleanup/book keeping and this was the cleanest way we could find. Once this is done we will have a clear and enforced development cicle and wont have any more force pushes, so please bear with me haha)