pipreqs icon indicating copy to clipboard operation
pipreqs copied to clipboard

scikitplot: incorrect extra requirement

Open bersbersbers opened this issue 5 years ago • 2 comments

user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt
user@host:~/temp> more requirements.txt 
scikit_plot==0.3.7
scikitplot==0.1.1

The last line should not be there.

bersbersbers avatar Oct 08 '20 11:10 bersbersbers

@bersbersbers I just tried out your code (to clarify another question) and was not able to reproduce your effect:

user@host:~> mkdir temp
user@host:~> cd temp
user@host:~/temp> echo import scikitplot > bug.py
user@host:~/temp> pipreqs 
INFO: Successfully saved requirements file in /home/bers/temp/requirements.txt

After I opened the requirements.txt I don't see the entry you've mentioned. Only this is in: scikitplot==0.1.1

squeezer44 avatar Oct 09 '20 22:10 squeezer44

@squeezer44 that is good enough as an example. I'm not sure why you don't get scikit_plot in there - either way, scikitplot is definitely incorrect. See https://pypi.org/project/scikitplot/:

A package to prevent exploit

bersbersbers avatar Oct 10 '20 05:10 bersbersbers