pipreqs
pipreqs copied to clipboard
bndr
Add support for jupyter notebook
Related Issue #51, #186, #199
Detail Add support for jupyter notebook. To parse notebook to python, used nbconvert library which officially provided by Project Jupyter.
note As known issue, .ipynb which uses magic command without % cause Error when parsing script with awk.process(). For now I just left comment to let the user notice it, if you have good idea to fix it, I will be appreciated if you tell me.
Sorry for continue reopening PRs, I finally could find the reason why my coverage decreased and fixed it, also checked if the ci and coverall works fine in my repo.
Coverage decreased (-0.5%) to 70.881% when pulling 5d57b4e7214529f9f1b47cfcd6599340453649c8 on pakio:add_notebook_support into 060f52f59774c2fb8e24698da0a74cc7f6cfb8c9 on bndr:master.
Coverage decreased (-0.5%) to 70.881% when pulling 7fb8d45cfdc3e083e670dad33caec7c9fa5c8def on pakio:add_notebook_support into 060f52f59774c2fb8e24698da0a74cc7f6cfb8c9 on bndr:master.
Hi @jamesmyatt cc @alan-barzilay , sorry for being stale for a long time. I just started to work on it again, but seeing an issue related to nbconvert. (issue, failing test)
This could be resolved once I update the nbconvert version to latest or near-latest, but they are not supporting python 3.6 anymore.
Do you have any plan to stop supporting python3.6 in the near future?
Im not a maintainer but Python 3.6 is EOL so dropping support makes sense.
Pereonally I'm in favour of small projects like this only supporting relatively few python versions for new releases. For example big projects often support 42 months of releases, like NEP29. But I would do less here. Remember that maintainers are volunteers.
If I were you, I'd remove 3.6 and possibly 3.7 if it makes it easier, and then ask if it's OK. Worst that can happen is you'll be asked to update it. Remember it's easier to ask forgiveness.
