gojenkins icon indicating copy to clipboard operation
gojenkins copied to clipboard

Client should avoid using TLD of job builds

Open fussybeaver opened this issue 5 years ago • 1 comments

Currently, the client API will be able to find jobs, but will fail to run job.getBuild if the jenkins server configuration is not set to the same URL as the URL set when instantiating the client.

This is because the client uses the embed URL to do further lookups:

https://github.com/bndr/gojenkins/blob/master/job.go#L124

Steps to reproduce:

  • Set the Jenkins server URL location to a random string.
  • Get a job instance and run GetBuild on it.

fussybeaver avatar May 28 '19 09:05 fussybeaver

Can confirm that this pull request fix issue.

Is there any reason why it was not merged? Can i help in any way?

bkupidura avatar Jan 10 '20 10:01 bkupidura