react-native-app-clip icon indicating copy to clipboard operation
react-native-app-clip copied to clipboard

Excluded Packages Fix

Open nathan-ahn opened this issue 1 year ago • 0 comments

Problem

Excluded packages doesn't work (#27) for certain packages.

use_expo_modules(exclude: ...) handles unlinking Expo modules using the same underlying functionality as autolinking exclude. However, from my experimentation, this doesn't affect certain, non-Expo-module packages. This pull request steals code from an older version of this package before this commit to steal and modify @react-native-community/cli-platform-ios/native_modules.rb. Kudos to @bndkt for putting together the original solution!

Concerns

I'm hesitant on whether this pull request should be merged into the library considering how hacky it is. Depending on the version of @react-native-community/cli-platform-ios, the replacement breaks (I used 13.6.6 and 14.0.0 when writing and testing this PR). Additionally, it seems that the autolinking functionality is being moved into the core React Native library instead of relying on @react-native-community/cli-platform-ios. In the future, this fix will break and this solution will have to be reworked for autolinking.rb.

nathan-ahn avatar Aug 02 '24 23:08 nathan-ahn