react-native-app-clip icon indicating copy to clipboard operation
react-native-app-clip copied to clipboard

Expo Updates, Info.plist and Compatibility

Open AlexandreFauchard opened this issue 1 year ago • 3 comments

Hello @bndkt !

Thank you for your library, it helps me a lot ! It broke with Expo 51, so I forked it and added some features I needed (Expo updates, Info.plist customization, Android and web compatibility) If you would like to add my improvements to the main library, I would appreciate it.

AlexandreFauchard avatar Jun 11 '24 09:06 AlexandreFauchard

Did you ever published the forked repo? Really interested in this!

calebpanza avatar Jun 18 '24 18:06 calebpanza

This would be a great addition; especially being able to include arbitrary entries into the App Clip's Info.plist.

There's a typo in infoPlistAdditionnalEntries—should be infoPlistAdditionalEntries. I wonder if it'd be better to match the Expo convention and just call that parameter infoPlist?

@bndkt—any chance this or something similar could be merged any time soon?

iveshenry18 avatar Sep 02 '24 20:09 iveshenry18

I now see that the plugin applies any properties in your main expo -> ios -> infoPlist to the app clip's Info.plist. That was sufficient for my case.

iveshenry18 avatar Sep 02 '24 20:09 iveshenry18

Hey @AlexandreFauchard ! I'm helping Benedikt out with maintaining this repository. I love the changes! Would you mind splitting out this PR, specifically the EAS Updates support and infoPlistAdditionalEntries changes? I already have a planned fix for Android and web compatibility that I aim to have merged in this weekend, so no need to worry about that.

If you're busy, I'm also happy to split this up myself; just didn't want to steal your changes.

nathan-ahn avatar Nov 22 '24 22:11 nathan-ahn

Closing due to inactivity

nathan-ahn avatar May 10 '25 20:05 nathan-ahn