tss-lib icon indicating copy to clipboard operation
tss-lib copied to clipboard

go vet issues

Open momaee opened this issue 2 years ago • 1 comments

Hi there. I am using go vet in my repo. I get an error in the case of getting signature data at the final round of signing.

assignment copies lock value to data: github.com/binance-chain/tss-lib/common.SignatureData contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex

Also if you use your codes, you will get the same error in https://github.com/bnb-chain/tss-lib/blob/30c5ee412a0ef9096ae37f67d6e0d5adcfdd551e/ecdsa/resharing/local_party_test.go#L209

ecdsa/resharing/local_party_test.go:209:20: copylocks: assignment copies lock value to signData: github.com/binance-chain/tss-lib/common.SignatureData contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)

momaee avatar Mar 22 '22 15:03 momaee

This PR could solve it. #167

yycen avatar Apr 01 '22 09:04 yycen