javascript-sdk icon indicating copy to clipboard operation
javascript-sdk copied to clipboard

Use a separate class for Account (keys, address)

Open Johnsavadkuhi opened this issue 6 years ago • 4 comments

client/index.js should be only for interacting with binance chain like send token , issue token and so

Johnsavadkuhi avatar Mar 14 '19 15:03 Johnsavadkuhi

If I am interpreting this correctly, I agree - it would be nice to have a separate Account (or similar) class to hold the address and private key.

notatestuser avatar Mar 24 '19 06:03 notatestuser

How do you feel about the structure proposed in #43?

notatestuser avatar Mar 24 '19 06:03 notatestuser

@notatestuser yes #43 is good structure but i have a question , why getBalance() and getAccount () in Account Class ? i recommend delete getBalance and getAccount and then put them in client/index

Johnsavadkuhi avatar Mar 24 '19 11:03 Johnsavadkuhi

@notatestuser

Screenshot (27)

Johnsavadkuhi avatar Mar 24 '19 14:03 Johnsavadkuhi