javascript-sdk icon indicating copy to clipboard operation
javascript-sdk copied to clipboard

client should be split into two pieces

Open notatestuser opened this issue 6 years ago • 2 comments

Right now client has methods that rely on this.privateKey and others that take parameters in arguments (such as checkAddress(address)). These separate concerns should be separated out into two classes.

notatestuser avatar Feb 18 '19 08:02 notatestuser

class Signer { } class BncClient {} , remove setPrivateKey in BncClient

Johnsavadkuhi avatar Mar 14 '19 13:03 Johnsavadkuhi

@Johnsavadkuhi putting it in a separate class is essentially the same thing in JS (security wise).

notatestuser avatar Mar 14 '19 14:03 notatestuser