javascript-sdk icon indicating copy to clipboard operation
javascript-sdk copied to clipboard

Remove the need for libusd/libudev when installing with --no-optional

Open stefanionescu opened this issue 6 years ago • 5 comments

I shouldn't need to install libudev-dev, libusb-dev and usbutils when I don't want Ledger support.

For now I had to fork this repo and eliminate all Ledger-related code so I don't get a "libusd not found" error when I npm install.

It would be nice to make an option where if I install with --no-option I don't need to also install the above mentioned deps.

stefanionescu avatar Sep 20 '19 08:09 stefanionescu

You can use --no-optional.

$ npm i @binance-chain/javascript-sdk --no-optional

From the readme: https://github.com/binance-chain/javascript-sdk#install-the-npm-package

notatestuser avatar Sep 20 '19 09:09 notatestuser

Closed by mistake. Let me know if there's something I'm missing here.

notatestuser avatar Sep 20 '19 09:09 notatestuser

I did use --no-optional and it still gave me an error saying something like "libudev not found"

stefanionescu avatar Sep 20 '19 11:09 stefanionescu

@stefanionescu can you try with yarn add @binance-chain/javascript-sdk --no-optional.

suraneti avatar Jan 07 '20 06:01 suraneti

I tried --no-optional and it still gives the same errors. For now I forked the repo and removed libusd/libudev entirely from the code

stefanionescu avatar Jan 07 '20 13:01 stefanionescu