bsc icon indicating copy to clipboard operation
bsc copied to clipboard

refactor: use t.TempDir() instead of os.MkdirTemp

Open tgolang opened this issue 9 months ago • 4 comments

Description

TempDir() is a method introduced in Go 1.15 for testing.T. It automatically creates a temporary directory and cleans it up after the test is complete, eliminating the hassle of manually handling errors and cleanup. More detail about TempDir https://pkg.go.dev/testing#B.TempDir

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

tgolang avatar Mar 08 '25 08:03 tgolang

Anything need I to do? I am happy to do it.

tgolang avatar Mar 15 '25 01:03 tgolang

@tgolang can you rebase latest develop, and resolve conflicts?

buddh0 avatar Nov 28 '25 01:11 buddh0

@tgolang can you rebase latest develop, and resolve conflicts?

Of course. The new pr: https://github.com/bnb-chain/bsc/pull/3479

Please review it again. Thanks! @buddh0

tgolang avatar Dec 06 '25 12:12 tgolang

نه متاسفانه انهادردسترس نیستندتابفرستم برای شما

در تاریخ شنبه ۶ دسامبر ۲۰۲۵،‏ ۱۵:۴۹ tgolang @.***> نوشت:

Reopened #2942 https://github.com/bnb-chain/bsc/pull/2942.

— Reply to this email directly, view it on GitHub https://github.com/bnb-chain/bsc/pull/2942#event-21400078593, or unsubscribe https://github.com/notifications/unsubscribe-auth/BELDIUR5W5YS47MSJHJYZU34ALCWJAVCNFSM6AAAAACNNSUBCKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRGQYDAMBXHA2TSMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

kuordstankm13545 avatar Dec 06 '25 23:12 kuordstankm13545