barefoot icon indicating copy to clipboard operation
barefoot copied to clipboard

email validation bug: preventing contact-us submission and access to bmwfs

Open coip opened this issue 4 years ago • 0 comments

caveat: this is unrelated to bmwcarit/barefoot, but about a real life customer with a very specific bug that should absolutely be backlogged/fixed somewhere, not lost in a ~less contextual support ticket from a CS Rep


reproduce in <30 seconds:

visit contactform.bmwusa.com, enter [email protected] for email, and hit submit. repeat with [email protected] to see a successful validation example, showing current ~arbitrary requirement of >= 2 characters

(above form link'd via https://www.bmwusa.com/contact-us.html)

image (my actual email hostname is my github username)

The above error code is categorically false:

1.) RFC-3696: Application Techniques for Checking and Transformation of Names, Sec.3 Restrictions on email addresses

2.) perhaps more reasonably straightforward: I use that email address. Every time. Every day. 😄


This validation error seems to have been causing some trouble on at-least one back end service as well. (see attached network log)

This issue has prevented me from any authorization/access to my bmwfs acct via web/mobile.

image

couldnt even sign up for autopay without a paper form physically mailed to me and returned otherwise.

the fix:

update the regular expressions found via: curl https://my.bmwusa.com/etc/designs/bmwusacontactus/clientlib-all.js | grep -n "var email_regex" (note the ...{2,}... in the response, requiring a localaddr length of at-least 2)

stackoverflow seems to have some answers w.r.t. a more-correct regex, and the idea of utilizing a pkg/lib instead.


feel free to delete/tag wontfix, but the >0% chance of this bug falling through the cracks with customer service makes me feel that opening an issue on y'alls github org would increase our chances for success.

coip avatar Mar 03 '20 02:03 coip