Brad Warren

Results 97 issues of Brad Warren

Like many Python projects, we use `tox` to run our tests. Unfortunately, we're pinning `tox` back at https://github.com/certbot/certbot/blob/9d8eb6ccfd513cf2bfd0c0920c9eb006ad536f4f/tools/pinning/current/pyproject.toml#L73-L77 I think this pinned back version will almost certainly break eventually and...

area: testing
area: pkging
area: tooling
priority: significant

Say you have the domain `important.example.org` and want to obtain a wildcard certificate. One way you could do that is make a CNAME record at `_acme-challenge.important.example.org` that points to `dnsprovider.example.com`....

feature request
area: security
has pr
area: dns

We use this function for comparing version strings but it's not type safe in a way that mypy doesn't currently check for. See https://github.com/certbot/certbot/issues/9481. Because of this, I personally think...

area: code health
priority: significant

See https://github.com/certbot/certbot/pull/9652.

area: ui / ux
area: testing
area: code health
priority: significant

Merge conflicts in our changelog are relatively common. There was some discussion about this issue and how to fix it in https://github.com/certbot/certbot/issues/6462. Another common problem is the changelog entry getting...

area: pkging
area: tooling
priority: significant

I've reproduced it on other systems, but on Ubuntu 18.04 with Python 2.7.17: ``` $ virtualenv -p python2 venv .Running virtualenv with interpreter /usr/bin/python2 New python executable in /tmp/tmp.QhBu6ZeQC4/venv/bin/python2 Also...

In my work on https://github.com/certbot/certbot/pull/9585, `unittest2pytest` rewrote these lines: ``` self.assertAlmostEqual(mock_sleep.call_args_list[1][0][0], interval - 1, delta=1) self.assertAlmostEqual(mock_sleep.call_args_list[2][0][0], interval/2 - 1, delta=1) ``` as ``` assert abs(mock_sleep.call_args_list[1][0][0]-interval - 1) < 1 assert...

This PR should not be squashed to preserve the signed and tagged commit.

Python 3.12 is out now. See https://github.com/certbot/josepy/pull/146 where we did this for Python 3.11.

priority: high

See https://github.com/certbot/certbot/issues/8322. I'm creating an issue here for more visibility. If people see this who know more about `python-jose`, I'd be interested to hear any concerns or support for this...

question
priority: significant