express-subdomain icon indicating copy to clipboard operation
express-subdomain copied to clipboard

Published 20 hours ago • verified publisher icon bmullan91

Adds exception to '@' case

Open immjs opened this issue 3 years ago • 6 comments

Thought it would be a nice addition to add root domains

immjs avatar Mar 25 '21 10:03 immjs

o/ is this good? I'm not very common with tests and socializing with other humans

immjs avatar Mar 27 '21 21:03 immjs

can you add some color to help me better understand why people would do this

Because sometimes you just want to handle the root domain, not forcibly the other ones

for instance, if I were to choose for 'api.example.com/about', id rather throw a 404 that would make sense to the dev than a successful request that would confuse them

immjs avatar Mar 27 '21 21:03 immjs

Hello? I really want this PR to get merged, it's gonna facilitate a lot of things for me and for other people asw (I hope) @bmullan91

immjs avatar Apr 28 '21 16:04 immjs

Hi!

So, to clarify, you can't go into any @ subdomain because in DNS it just means root.

Since it is the norm, I would expect to see it here as well

immjs avatar Oct 15 '22 09:10 immjs