Bryant Moscon

Results 121 comments of Bryant Moscon

not really. Its a LOT of code change due to how version store reads symbols. Its not a simple lookup, it does a lot of work related to the versioning...

@TomTaylorLondon if you want the history on the passthrough chunker, we can talk offline. Someone internal needed it to write non timeseries data. It may or not be needed anymore.

@scoriiu if you want to get this merged in, you'll need to add a test case that illustrates the issue and then is fixed with your fix. You can add...

It sounds like you are using tickstore incorrectly. It has some interval requirements about how data is written

@BaiBaiHi there are other things deprecated that are breaking the build as well. I'm working on fixing them. @jamesblackburn whats the min mongodb version we need to support? 3.4 is...

I've already updated the version of mongo on my branch that addresses a lot of the deprecations and what not, so once thats merged in, this branch can be rebased...

@BaiBaiHi can you rebase your fork off mainline? I updated many things to fix the build, so assuming after that the tests pass on this PR we can get it...

@BaiBaiHi sure but can you fix the style issues? arctic/chunkstore/chunkstore.py:278:55: W291 trailing whitespace arctic/chunkstore/chunkstore.py:282:27: E261 at least two spaces before inline comment arctic/chunkstore/chunkstore.py:282:134: W291 trailing whitespace

@jamesblackburn it seems reasonable and it passes all the tests. I'm not sure how it will perform if actually need to spill out onto disk

@BaiBaiHi @jamesblackburn what do you want to do with this?