Bryan Mishkin

I fixed the conflicts, tests, and many (but not all) of the comments. There's another comment here that may need to be addressed still: https://github.com/ember-template-lint/ember-template-lint/issues/44#issuecomment-218965427

@JoaoDsv if you'd like to finish this PR up, let us know. Otherwise, I think @bertdeblock and I will try to finish it up. @bertdeblock, I'll give you access to...

To be clear, I do think we should address this comment to reduce false positives: https://github.com/ember-template-lint/ember-template-lint/issues/44#issuecomment-218965427 I'm not going to work on this now so @bertdeblock you can take over...

Looks good except we still need the parent `` check.

@JoaoDsv thanks for your continued work on this. Let us know when it's ready (with my last comment addressed).

I do think it would be nice for us to support both ESM plugins and TypeScript plugins. The plugin generator could ask: ``` What type of plugin do you want...

Hey @tclindner that's a fair point. Unfortunately, I'm not currently aware of any popular alternatives. Feel free to close this if you're not interested. Some points in favor of using:...

Just FYI you need to use the syntax "Fixes #000" so that the PR will automatically resolve the issue when merged.

Ignore Node 18 CI. Preexisting issue.

> Just FYI you need to use the syntax "Fixes #000" so that the PR will automatically resolve the issue when merged. This needs to be in the PR description.