Bryan Mishkin comments

Results 335 comments of


                                            Bryan Mishkin

Rule banning complex ESQuery selectors

We'd welcome a rule for this, as some plugin authors may prefer to avoid complex selectors. However, I would lean toward any such rule to be optional and not recommended....

Automate docs with eslint-doc-generator

@dangreenisrael > If you want to do a cleanup to remove old rules, could you do that in a separate PR? Removing docs for deleted rules in https://github.com/dangreenisrael/eslint-plugin-jest-formatting/pull/118. > Also,...

Automate docs with eslint-doc-generator

Can someone approve CI to run? This is still ready to go in. @dangreenisrael @twelve17 @hockeybuggy

Automate docs with eslint-doc-generator

@dangreenisrael yes still ready to go.

Add eslint-plugin-import to ember-cli blueprint

@ef4 thanks for the context. I have updated the RFC to disable the `import/no-unresolved` lint rule to get around the current infeasibility of reliably resolving imports. We can always come...

fix: allow readonly array input for table data

Nope, not a breaking change. It allows read-only arrays but does not require them. It expands the allowed input.

fix: allow readonly array input for table data

Ping? Again, this is not a breaking change.

fix: allow readonly array input for table data

Ping?

ember/no-deprecated-router-transition-methods breaks when route uses a mixin

@rtablada

"service" import not treated the same as "inject as service"

I think this is related to how many rules started out just looking for `service()` instead of actually checking the name it was imported. I fixed a lot rules (https://github.com/ember-cli/eslint-plugin-ember/issues/590)...