Bryan Mishkin comments

Results 359 comments of


                                            Bryan Mishkin

no-array-prototype-extensions fix is unsafe

CC: @tgvrssanthosh @smilland

no-array-prototype-extensions fix is unsafe

Can someone test to confirm? Is there an autofix that will work for this?

no-array-prototype-extensions fix is unsafe

1. Are there improvements we could make to the autofixer, such as heuristics to detect and avoid this unsafe situation? 2. Is this issue specific to Ember Data usage? 3....

Rules do not work with named exports

Thanks for your interest in using and contributing to our plugin! Here's why we don't support your setup yet: 1. While we support the `ESLintUtils.RuleCreator` helper when used directly, we...

False Option warning on Windows

Thanks for the detailed report. I haven't been able to test on Windows yet but I suspect I have a fix in #524.

False Option warning on Windows

Let me know if https://github.com/bmish/eslint-doc-generator/releases/tag/v1.7.1 fixes this.

Duplicated auto-generated rules header on Windows

Thanks for the detailed report. I haven't been able to test on Windows yet but I suspect I have a fix in #524.

Duplicated auto-generated rules header on Windows

Let me know if https://github.com/bmish/eslint-doc-generator/releases/tag/v1.7.1 fixes this.

Tweak emoji placement in rule doc config notice when combination of enabled/warn/disabled present

@ljharb I've implemented separate lines (proposal 2 in the issue description) in #311. The implementation is trivial. The situation would have been more complex had I gone with Proposal 3...

Tweak emoji placement in rule doc config notice when combination of enabled/warn/disabled present

I'm going to ponder on this a bit more to decide if I want to bite the bullet and try out Proposal 3 for better future-proofing.