vscode-intelephense icon indicating copy to clipboard operation
vscode-intelephense copied to clipboard

Add support for VS Code Inlay Hints

Open modscleo4 opened this issue 4 years ago • 7 comments
trafficstars

Feature description or problem with existing feature There is an extension called VS Code Inline Parameters (https://github.com/imliam/vscode-inline-parameters), but it's super slow and CPU heavy. VS Code 1.60 added native support for Inlay Hints (and JS/TS already have it). I didn't find any issue related to Inlay or Inline, so I opened one.

Describe the solution you'd like In JS/TS, it shows hints for Enums, function return types, parameter names, parameter types, property types and variable types.

Additional context Screenshot_20210903_113831

modscleo4 avatar Sep 03 '21 12:09 modscleo4

We can call it PARAMETER HINT feature And yes, it's a great idea. It would be great to have this feature in Intelephense

PS. There is an add-on like https://marketplace.visualstudio.com/items?itemName=robertgr991.php-parameter-hint but at first glance not work properly

kanlukasz avatar Oct 11 '21 16:10 kanlukasz

If I understand it correctly the necessary API within VS Code has been finalized:

https://github.com/microsoft/vscode/issues/16221#issuecomment-1033827087

TimWolla avatar Feb 09 '22 15:02 TimWolla

The Inlay Hint provider API is now finalized on VS Code 1.65

modscleo4 avatar Mar 04 '22 12:03 modscleo4

Unfortunately, this needs modifications on the LSP Server, which is (at least I think) closed source. Java people managed to implement inlay hints both on client and server, these are the Pull Requests: https://github.com/eclipse/eclipse.jdt.ls/pull/2019/files https://github.com/redhat-developer/vscode-java/pull/2354/files

I managed to adapt the client, but this will not work without the required modifications in the server https://github.com/modscleo4/vscode-intelephense

modscleo4 avatar Apr 20 '22 01:04 modscleo4

Any news on this ? This would be a awesome feature to have :D

Vincent-HD avatar Feb 20 '23 09:02 Vincent-HD