Benedikt Meurer
Benedikt Meurer
cc @gsathya @caitp
cc @jaro-sevcik
@mcollina My gut feeling is that we will need some kind of micro-benchmarks to drive individual work items. Plus real-world code to see overall impact and find appropriate areas worth...
> > Is the `kResolve` hook useful? > `kResolve` is used by https://github.com/angular/zone.js/pull/795 - but it is not enough for what they want. Either they need the resolved value or...
@benjamingr The thing with promise hooks (as required by `async_hooks`) is that we need to pass the `JSPromise` object to Node, which immediately makes all escape analysis useless as TurboFan...
That's not how it's implemented currently. I think I need to look at the Node core side again. Don't you need to slap ids onto the `JSPromise` object?
@AndreasMadsen But we still need to materialize the `JSPromise` object to pass it to the `kInit` hook. So you already defeat the escape analysis at that point. Would it be...
@AndreasMadsen Staring at the `PromiseHook` on the Node side, you store the `PromiseWrap` object on the `JSPromise` and you do check the parent `JSPromise` during `kInit`. So this would be...
Very interesting. Thanks for sharing. cc @thomasnat1
Also see the first item on the list for https://github.com/nodejs/diagnostics/issues/124.