Bradley Farias

Results 379 comments of Bradley Farias

I'd note that this does impact other areas like policies and whatever decisions we make should likely be documented and agreed upon across the whole project.

I do like the API being usable to determine either require or import personally.

> do you mean via the distinction of require.resolve and import.meta.resolve, or do you mean enabling an option into the resolve function? I mean having 1 function that I can...

That's good feedback, thanks :)

bump in light of this seeming to be relevant to https://github.com/nodejs/node/issues/30514

At the top level `this` differs between Script and Module. ```mjs // maybe "use strict" here if you wanna have a Strict Script let isModule = this === void 0;...

@SMotaal are you still wanting to pursue adding `import.meta` to Script or is that enough?

I'll be rather busy in the next week as will several others I'm sure so we might want to setup a timeline to avoid this being under reviewed and/or just...

> That sounds like a bug or at least unexpected behavior. The loader for the entry point should be determined by the file format of the entry point, not by...

I know that Chrome ties their loader Module Map to Context data using `Context::GetEmbedderData`, and that V8 has warned us to not have the C++ resolution resolve to a Module...