toasted-notes icon indicating copy to clipboard operation
toasted-notes copied to clipboard

support for custom animation

Open iTonyYo opened this issue 5 years ago • 3 comments

If you can support custom animation, it will be more flexible.

Message.tsx#L93

iTonyYo avatar Dec 10 '19 10:12 iTonyYo

How would you feel about the library using react-transition-group, which would allow us to customize the animations using CSS. The react-spring seems like overkill for this use case, and it isn't very performant for me.

baleeds avatar Apr 10 '20 12:04 baleeds

Plus it's an extra dep, which just doesn't seem necessary.

baleeds avatar Apr 10 '20 12:04 baleeds

Happy to accept a PR for react-transition-group support, and agree that CSS animations would be preferable for an independent library. I built this for use within a project which included react-spring, so I wasn't worried about the extra dep.

bmcmahen avatar Apr 16 '20 03:04 bmcmahen