robovac icon indicating copy to clipboard operation
robovac copied to clipboard

Update needed for HA 2023.8

Open iridris opened this issue 2 years ago • 16 comments

The beta for HA Core 2023.8 is now released and is displaying a warning for this integration:

The robovac custom integration is using deprecated vacuum feature This stops working in version 2024.2.0. Please address before upgrading. The custom integration robovac is extending the deprecated base class VacuumEntity instead of StateVacuumEntity.

Please report it to the author of the robovac custom integration.

Once an updated version of robovac is available, install it and restart Home Assistant to fix this issue. image

iridris avatar Jul 26 '23 19:07 iridris

same here

DariukaB avatar Aug 02 '23 21:08 DariukaB

Same

Redding43 avatar Aug 02 '23 21:08 Redding43

I'd take a look if I had a moment, but for now, I'll link to the relevant blog for convenience: Updated to the Vacuum entity integration Edit: skimming the details in the blog, looks like it might be over my head (that doesn't take much! but I help where I can.)

pem884 avatar Aug 02 '23 23:08 pem884

Same here. Hope we get to use robovac integration in HA soon :) Thank you for your great work

morpheus302 avatar Aug 03 '23 00:08 morpheus302

Same in my Installation.

image

Thank you for your wonderful work.

Uwe80469 avatar Aug 03 '23 10:08 Uwe80469

I have restored my last snapshot and went back to 2023.7 for now.

xhemp avatar Aug 03 '23 10:08 xhemp

I have restored my last snapshot and went back to 2023.7 for now.

restored it too :) waiting the update for eufy robovac

DariukaB avatar Aug 03 '23 10:08 DariukaB

Same problem here. Waiting for an uopdate.

pheijms avatar Aug 03 '23 11:08 pheijms

There's a fix available in #31.

pwcazenave avatar Aug 05 '23 10:08 pwcazenave

Worked for me 👍

DariukaB avatar Aug 05 '23 13:08 DariukaB

It should still work for now. This is just a warning that it will stop working with the February update.

michaelmior avatar Aug 07 '23 14:08 michaelmior

It should still work for now. This is just a warning that it will stop working with the February update.

It doesn't without applying the fix

DariukaB avatar Aug 07 '23 14:08 DariukaB

Give it a try with this one https://github.com/CodeFoodPixels/robovac

blackwhitemint-coder avatar Aug 08 '23 19:08 blackwhitemint-coder

The current implementation passes something unexpected to a class and causes it to raise an exception in the latest version of home assistant, which is why it isn't working.

Given that the maintainer of this integration hasn't been active on GitHub since December 2022, I've forked this repo with a view to maintain it along with anyone else who would like to help.

Fork is here, but happy to consider setting up an org or whatever: https://github.com/CodeFoodPixels/robovac

CodeFoodPixels avatar Aug 08 '23 20:08 CodeFoodPixels

I have seen the same error as others and additionally the integration is unable to setup the devices:


2023-08-20 15:55:45.094 INFO (MainThread) [homeassistant.components.vacuum] Setting up vacuum.robovac
2023-08-20 15:55:45.123 WARNING (MainThread) [homeassistant.components.vacuum] robovac::RoboVacEntity is extending the deprecated base class VacuumEntity instead of StateVacuumEntity, this is not valid and will be unsupported from Home Assistant 2024.2. Please report it to the author of the 'robovac' custom integration
2023-08-20 15:55:45.174 INFO (MainThread) [homeassistant.components.calendar] Setting up calendar.local_calendar
2023-08-20 15:55:45.178 ERROR (MainThread) [homeassistant.components.vacuum] Error adding entities for domain vacuum with platform robovac
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 619, in _async_add_entity
    device = dev_reg.async_get(self.hass).async_get_or_create(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DeviceRegistry.async_get_or_create() got an unexpected keyword argument 'access_token'
2023-08-20 15:55:45.355 INFO (MainThread) [homeassistant.components.button] Setting up button.plex
2023-08-20 15:55:45.357 ERROR (MainThread) [homeassistant.components.vacuum] Error while setting up robovac platform for vacuum
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 370, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 619, in _async_add_entity
    device = dev_reg.async_get(self.hass).async_get_or_create(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DeviceRegistry.async_get_or_create() got an unexpected keyword argument 'access_token'

teskanoo avatar Aug 20 '23 23:08 teskanoo

I have seen the same error as others and additionally the integration is unable to setup the devices:


2023-08-20 15:55:45.094 INFO (MainThread) [homeassistant.components.vacuum] Setting up vacuum.robovac
2023-08-20 15:55:45.123 WARNING (MainThread) [homeassistant.components.vacuum] robovac::RoboVacEntity is extending the deprecated base class VacuumEntity instead of StateVacuumEntity, this is not valid and will be unsupported from Home Assistant 2024.2. Please report it to the author of the 'robovac' custom integration
2023-08-20 15:55:45.174 INFO (MainThread) [homeassistant.components.calendar] Setting up calendar.local_calendar
2023-08-20 15:55:45.178 ERROR (MainThread) [homeassistant.components.vacuum] Error adding entities for domain vacuum with platform robovac
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 619, in _async_add_entity
    device = dev_reg.async_get(self.hass).async_get_or_create(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DeviceRegistry.async_get_or_create() got an unexpected keyword argument 'access_token'
2023-08-20 15:55:45.355 INFO (MainThread) [homeassistant.components.button] Setting up button.plex
2023-08-20 15:55:45.357 ERROR (MainThread) [homeassistant.components.vacuum] Error while setting up robovac platform for vacuum
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 370, in _async_setup_platform
    await asyncio.gather(*pending)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 510, in async_add_entities
    await asyncio.gather(*tasks)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 619, in _async_add_entity
    device = dev_reg.async_get(self.hass).async_get_or_create(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: DeviceRegistry.async_get_or_create() got an unexpected keyword argument 'access_token'

Have you tried moving over to using the fork specified in the previous post? If not, please do so. It is working well for me with the fork. Then, if there are any concerns with the fork, it may be appropriate to raise an issue under that fork.

pem884 avatar Aug 21 '23 17:08 pem884