automatically comment out the .hide rule

[ds125v]

Mostly a reminder to myself:

Bootstrap has deprecated .hide for .hidden, .hide is one of our nameclashes. So we don't use it, and if Bootstrap have stopped using it in their code (need to double check that) we could add a grunt task to the compile that looks for that line and add "//" before it to comment it out.

This is better than just deleting it as you don't have to remember to do it every time you update the upstream .less files.

Once that's done there's a few lines of overrides we can delete.

Also related, Moodle core has span.hide and div.hide having the rule "display:none". They're commented as being accessability features, but I don't understand how hiding stuff from everyone is an accessability feature. Needs investigation.

[3-bits]

The .hide was used for the screen readers but as far I know actually they process the display: none (at least Jaws) so the recommended would be:

.hidden { display: none; visibility: hidden; }

It should works in all the screen readers or at least in the most used

Regards

Fernando Acedo

On Fri, Mar 28, 2014 at 10:21 AM, David Scotson [email protected]:

Mostly a reminder to myself:

Bootstrap has deprecated .hide for .hidden, .hide is one of our nameclashes. So we don't use it, and if Bootstrap have stopped using it in their code (need to double check that) we could add a grunt task to the compile that looks for that line and add "//" before it to comment it out.

This is better than just deleting it as you don't have to remember to do it every time you update the upstream .less files.

Once that's done there's a few lines of overrides we can delete.

Also related, Moodle core has span.hide and div.hide having the rule "display:none". They're commented as being accessability features, but I don't understand how hiding stuff from everyone is an accessability feature. Needs investigation.

Reply to this email directly or view it on GitHubhttps://github.com/bmbrands/theme_bootstrap/issues/230 .

[ds125v]

The only use of span.hide I've found so far is to wrap around some pipe characters ( | ) used as seperators n the calendar lib. I can't figure out why you'd want to hide them via CSS rather than just not output them in the first place.

[gjb2048]

Did they not remove the user screen reader setting after M1.9? So have no server side screen reader detection code.

Would using ARIA roles be a better solution?

Sent from my iPod in deep space...

On 28 Mar 2014, at 10:25, David Scotson [email protected] wrote:

The only use of span.hide I've found so far is to wrap around some pipe characters ( | ) used as seperators n the calendar lib. I can't figure out why you'd want to hide them via CSS rather than just not output them in the first place.

— Reply to this email directly or view it on GitHub.

[3-bits]

I used Jaws in the past and some special characters were used as separators, pauses or breakpoints while speaking. So probably as Gareth said, it still an old class from 1.x. but not sure if it could be removed.

Now I don't have access to Jaws so can't test the result if removed.

Regards

3bits - elarning solutions

On Fri, Mar 28, 2014 at 11:25 AM, David Scotson [email protected]:

The only use of span.hide I've found so far is to wrap around some pipe characters ( | ) used as seperators n the calendar lib. I can't figure out why you'd want to hide them via CSS rather than just not output them in the first place.

Reply to this email directly or view it on GitHubhttps://github.com/bmbrands/theme_bootstrap/issues/230#issuecomment-38905230 .