ges-client
ges-client copied to clipboard
bmavity
Tcp disconnect doesn't emit an error on tcpConnection
When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.
Right now there is no way to know that we are disconnected, so we can't take any compensating actions.
I think I could submit a PR for this one.
In the other clients we have events that get passed back and we have reconnection etc strategies to prevent people from writing the same boilerplate.
On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze [email protected] wrote:
When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.
Right now there is no way to know that we are disconnected, so we can't take any compensating actions.
I think I could submit a PR for this one.
— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41.
Studying for the Turing test
Things stalled a bit before I got to the connection events. I am preparing a new release, but can't promise if connection events would get in. However, I would not be opposed to a pull request. :)
B
On Wed, Aug 26, 2015 at 11:42 AM, Greg Young [email protected] wrote:
In the other clients we have events that get passed back and we have reconnection etc strategies to prevent people from writing the same boilerplate.
On Wed, Aug 26, 2015 at 7:41 PM, Nicolas Dextraze < [email protected]> wrote:
When the underlying tcp connection is disconnected by an error the error doesn't bubble up to the tcpConnection.
Right now there is no way to know that we are disconnected, so we can't take any compensating actions.
I think I could submit a PR for this one.
— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41.
Studying for the Turing test
— Reply to this email directly or view it on GitHub https://github.com/bmavity/ges-client/issues/41#issuecomment-135102625.
Yeah Greg I know.
For now I only want to have the error bubble up as a start, but eventually it would be nice to have the reconnect done by the ges-client too.
We're about to go into alpha for our product today using ges-client and GES so I guess we'll see a lot of issues. I'll try to get the OK to submit PR fixes for issues we see and can fix.
Thanks.