Benjamin Marwell

Results 405 comments of Benjamin Marwell

> I think the problem can be this one about api change: > > public void setEnvironment(Map env) { > > For now user can put any type in the...

@lprimak just modify your branch to leave that one out and merge it into 2.0.1 Then do another for 3.0.0 with that change.

Thanks! Do you think you could add a junit test? There are sshd mock servers you could use.

The correct place would be the user's settings.xml file. But I'm not sure of there's a place for it yet.

@lppedd I second what @elharo says. Do you have a JIRA account or should I just create an issue for you?

> As I wrote in the description, this PR intends to add prefix like a parent directory. For example, I want to package jlink'ed image like this. (full of `pom.xml`...

Hi @Til7701 -- you are right, CDS is a hotspot-specific thing, but other Java vendors like IBM may chose to replace hotspot and its CDS with something else -- like...

OK, one more thing. The option `generate-cds-archive` cannot be used before Java 17. The files you added (e.g. `src/it/projects/cli-options/additional-args/invoker.properties`) should reflect this. You need to add `invoker.java.version = 17+`.

+1 I would love to see that, too. JSON-only should work, too (any client certificate present, client certificate matching subject present, etc).