name-db icon indicating copy to clipboard operation
name-db copied to clipboard

Test alphabet and lang relation

Open aurium opened this issue 8 years ago • 4 comments

Using unicharadata module to help testing char alphabet.

Closes #215

aurium avatar Oct 29 '17 06:10 aurium

Plus: I found some bad data structure, that i corrected. The tests are showing alphabet mistakes, that i leave for someone with more lang knowlege to solve. (and that is why checks will fail on travis)

aurium avatar Oct 29 '17 06:10 aurium

Hey @aurium, thanks!

The code looks great, but it doesn't seem to be so accurate. I think it's because testing every single letter is not the best approach, because there are letters that being used in multiple alphabets.

For examplt: AssertionError [ERR_ASSERTION]: The char "c" of "алекcaндр" is LATIN, expected to be CYRILLIC (lang rus).

Don't you think?

bluzi avatar Oct 29 '17 23:10 bluzi

Hi @bluzi! I don't know about char reuse. If you are sure about the same "c" is used on Latin and Cyrillic, i can update the alphabet test to accept it. There is more other special cases?

aurium avatar Nov 08 '17 05:11 aurium

There is more other special cases in (Cyrillic==Latin)?

aurium avatar Nov 12 '17 04:11 aurium