Andre Wachsmuth
Andre Wachsmuth
> That is great about sourcemapping and comments that is exactly what I want! I didn't test this PR i was just thinking out loud. > > a separate *.js.LEGAL.txt...
> should all depenedencies in package.json not use the hat ^ technique and declare exact versions. I think it will make things clearer and also make dependabot checks clearer and...
> everything is implicit because we use the global scope for 15 years. I have been thinking about what a modern solution would look like. It would be hard /...
> I definitely hear what you are saying about code splitting but i just worry this gets us so far away from JSF basics and the @resourcedependency stuff and it...
Just a quick status update: The tests and everything are passing now. But before we merge this, I wanted to make sure I knew exactly how the final result with...
@melloware Another thing I just noticed: PrimeFaces extensions still creates widget classes via `BaseWidget.extend(...)` That won't work anymore. * It might be possible to transpile the classes down to functions+prototypes...
One question regarding moment locales: How / when are these loaded? * [moment/moment.js](https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/moment/moment.js) doesn't include any locales, so users need to load these themselves? * But [timeline/0-vis-timeline.js](https://github.com/primefaces/primefaces/blob/master/primefaces/src/main/resources/META-INF/resources/primefaces/timeline/0-vis-timeline.js#L5842) contains some locales...
@melloware Hmm, I see. The ideal way imo would be * We include the locale data in our `locales/de.js` * When the timeline widget is *initialized*, we define the moment...
Actually, I just had an idea that we could use a function with a dynamic imports like this in our locale: ```js // locales/locale-es.js PrimeFaces.locales['es'] = { ..., loadMomentLocale: ()...
~~Hmm, that only seems to work in the root directory. When using the refresh command in a subfolder, elFinder makes sends an `tree` command where it also merges the root...