blur
blur copied to clipboard
Enhancement: rewrite of epee library (partial, at least)
Not liking the things in that library. Historically, its been a source of a fairly large problem at least once (Cisco Talos). Comments in code don't seem to be happy with it either... which draws similar attention to p2p.
- IP addressess handled irresponsibly...
- Removed a gif-content-type from the
http_base.h
header file - For some reason we have code that handles all kinds of media/web files (?) -https://github.com/blur-network/blur/blob/8fa472503688c8a463dc225af99377d40ffaa556/contrib/epee/include/net/http_protocol_handler.inl#L663-L688 (Surely, most of this is probably very unnecessary)
Consider partial rewrite.
epee namespace appears to be using ssize_t
everywhere std::size_t
occurs. since size_t is not always portable, this could be the reason... but can we need to make sure that std::size_t
should indeed be a ssize_t
as compiler says ... or, if it should be a size_t
as name implies... we should make this clearer.
Other places this was occurring, as far as the linker was concerned:
-
src/checkpoints/checkpoints.cpp
-
external/easylogging.h
-
contrib/epee/include/misc_log_ex.h
-
src/crypto
&src/crypto/crypto-ops
in various files
Similarly, there is a special case going on with streams. If this is simply for portability -- great. No problems. But make the customized types less confusing
Something found when building the snap for v0.1.9.6 (snapcraft core uses ubuntu:16.04)

Definitely worth looking into what exactly is going on here... as it may be the cause of some of the p2p oddities, and looks to have the ability to affect everything that uses endpoint addresses.