Amir Blum

Discussion(instrumentation-aws-sdk): SQS receive according to semantic conventions

5

This issue is to document the implementation of aws SQS receive operation according to the current semantic conventions for messaging systems (Oct 2021). there is an active SIG working on...

Use newer node version for browser tests and code coverage

2

In #1417 I attempted to upgrade the node version used for the browser test from 14 (which is EOL) to 18. Since we are also running special code coverage workflows...

error from fsnotify.NewWatcher() not checked, causing panic

2

**What happened**: I got a panic in my application when using this code: ``` manager := dpm.NewManager(lister) manager.Run() ``` StackTrace: ``` panic: runtime error: invalid memory address or nil pointer...

exception while running latest master in Development Mode

2

I followed the instruction in README, run `halin` locally on master: ``` halin git:(master) git rev-parse origin/master c736e767515abbe0844c9a695b3f9ff8d63d92d2 ``` After connecting to the database and pressing Diagnostic, I got the...

feat(instrumentation): remove default value for config in base instrumentation constuctor

2

This PR makes the `config` object for base instrumentations (node + browser), required instead of optional with default value empty object. ## Motivation The current implementation of instrumentation base classes...

This PR includes the following fixes: - apply `Lint changelog file` CI step to all markdowns and not only the one in the repo root. This introduced few fixes to...

Which unordered list style to use for markdowns

4

It seems the codebase is not consistent with how unordered lists are used in markdown. Some use dash `-` like [`@opentelemetry/api`](https://raw.githubusercontent.com/open-telemetry/opentelemetry-js/main/api/README.md), and other use asterisk `*` like [`opentelemetry@context-async-hooks`](https://raw.githubusercontent.com/open-telemetry/opentelemetry-js/main/packages/opentelemetry-context-async-hooks/README.md) This came...

Access patterns to config in instrumentations

4

Now that https://github.com/open-telemetry/opentelemetry-js/pull/4659 will soon merge, all instrumentations can apply cleanups to how the config object is consumed. There are now 2 options: 1. using `this._config` from `InstrumentationAbstract` which is...

Instrumentation "enabled" configuration inconsistent with OpenTelemetry

6

The "@opentelemetry/instrumentation" defines a generic [InstrumentationConfig interface](https://github.com/open-telemetry/opentelemetry-js/blob/31eb60dc99dc066cf2085864f2727eb29ee76e91/experimental/packages/opentelemetry-instrumentation/src/types.ts#L65): ```ts export interface InstrumentationConfig { /** * Whether to enable the plugin. * @default true */ enabled?: boolean; } ``` This interface defines...

How to make metadata accessible

3

I am exploring ways to enhance our handling of metadata for instrumentations, aiming to streamline processes and boost efficiency. Instrumentation (or OpenTelemetry component) metadata comprises static information about OpenTelemetry JS...