Daniel Hahler

Results 1440 comments of Daniel Hahler

You must be using some plugin for resizing the quickfix window already, vim-qf maybe? Try https://github.com/blueyed/vim-qf_resize instead / additionally.

Ah, I see now - forgot that we had that code there: https://github.com/neomake/neomake/blob/62d33650a07c5a4291946defe86dab9f19056d8c/autoload/neomake.vim#L910-L926 Thanks for looking at the code also - I think https://github.com/neomake/neomake/pull/1974 should improve this. Can you test/review...

@jfelchner I've just noticed that this causes an issue with https://github.com/blueyed/vim-qf_resize, which handles automatic resizing. I'm now using Neomake's method myself (had something custom before). E.g. after `lwindow 2` for...

As for Neomake and the common use case I could also imagine to delay the initial `lwindow`: it could be done unconditionally only at the end of all jobs, but...

Yeah.. Would be good if you could try https://github.com/neomake/neomake/pull/2011 and provide feedback there.

@jfelchner Thanks for the feedback. I am a bit uncertain about if the complexity of it is good, and thoiught about using `g:neomake_open_list_resize_existing = 0` by default, too. Also https://github.com/neomake/neomake/commit/3d89088f70699947f5b091face520136d269bfff#r29870808.

@jfelchner You are not using https://github.com/neomake/neomake/pull/2011 then, are you? (but have tried it back then, right?) I think it adds too much complexity in the first place (i.e. two new...

@facundobatista The related code is here: https://github.com/neomake/neomake/blob/acbbd0e0ce2277c33926c189d0f54825e2ed59d3/autoload/neomake.vim#L981-L1051 (and quite complex already ;)) I suggest debugging/looking at it via the logfile / adding `echom`s to see what is going on in...

So this is mainly implementing/using sign groups and priority with newer Vim/Neovims? (see `:h sign-group`, and `:h sign-priortiy`) For reference: this is how vim-gitgutter used the new functions: https://github.com/airblade/vim-gitgutter/commit/cbaa22e Related:...

Please include the log here also.