awesome-cyclefocus icon indicating copy to clipboard operation
awesome-cyclefocus copied to clipboard

Problem with quake dropdown terminal from copycats/lain

Open tataxax opened this issue 7 years ago • 2 comments

Hi, I ran into the following problem. When I do "Alt-tab" (focus previous window), that is already closed dropdown terminal window (native quake dropdown terminal from copycats/lain) then an error happened:

"../awesome/cyclefocus/init.lua:604: attempt to index a nil value (local 'c_tag')"

If there is any way to fix this issue ?

tataxax avatar Mar 16 '18 17:03 tataxax

It seems the dropdown has no tag attached (anymore)?

Please try the following patch:

diff --git i/init.lua w/init.lua
index fe47736..2e497d7 100644
--- i/init.lua
+++ w/init.lua
@@ -601,7 +601,9 @@ cyclefocus.show_client = function (c)
                     t.selected = false
                 end
             end
-            c_tag.selected = true
+            if c_tag then
+                c_tag.selected = true
+            end
 
             -- Restore.
             c.sticky = restore_sticky

I wonder if there are other properties that should be looked at to e.g. ignore this client altogether? I guess it gets hidden somehow, e.g. by not assigning it to any tag - but is there something else? Do you expect Alt-Tabbing to select the dropdown (even if it was not closed)?

/cc @copycats

blueyed avatar Mar 18 '18 11:03 blueyed

Hi,

Do you expect Alt-Tabbing to select the drop down (even if it was not closed)?

I want to simply exclude it from Alt-Tab process at all )). But I do not how to do it.

tataxax avatar Mar 19 '18 11:03 tataxax