Checkmate icon indicating copy to clipboard operation
Checkmate copied to clipboard

Modals display centered relative to the viewport, not their container

Open ajhollid opened this issue 10 months ago • 11 comments

Expected behaviour: Modal displays in the center of its parent component

Actual behaviour: Modal displays in the center of the viewport

Image

ajhollid avatar Feb 06 '25 17:02 ajhollid

@ajhollid can I work on this bug?

bhavesh26 avatar Feb 06 '25 18:02 bhavesh26

@ajhollid can I take this on?

Br0wnHammer avatar Feb 06 '25 19:02 Br0wnHammer

@bhavesh26 assigned to you. Thank you!

@SoloDevAbu if you have an issue with the application, do not comment on an arbitrary issue - please ask your question in the Github Discussions area.

gorkem-bwl avatar Feb 08 '25 16:02 gorkem-bwl

@ajhollid , @gorkem-bwl
https://github.com/bluewave-labs/Checkmate/pull/1728 Please review and merge

bhavesh26 avatar Feb 09 '25 16:02 bhavesh26

Hey @gorkem-bwl, I think we can complete this too before the new version launch. What say?

Br0wnHammer avatar Mar 17 '25 17:03 Br0wnHammer

Sure, go ahead and create a PR for this please.

gorkem-bwl avatar Mar 17 '25 17:03 gorkem-bwl

i want to fix it.

Aditya-singh-divineboy avatar Mar 26 '25 11:03 Aditya-singh-divineboy

i want to fix it.

Hello @Aditya-singh-divineboy, a PR is already open addressing this issue. Feel free to contribute there if you have any specific idea.

Br0wnHammer avatar Mar 26 '25 12:03 Br0wnHammer

@Aditya-singh-divineboy you can go ahead with this issue.

gorkem-bwl avatar Apr 16 '25 15:04 gorkem-bwl

Hey @gorkem-bwl

May I tackle this issue.

Trained-Monkey avatar May 12 '25 15:05 Trained-Monkey

Yes, please. Thank you.

gorkem-bwl avatar May 13 '25 02:05 gorkem-bwl

Hi! I'm new to open source and I’d love to work on this issue.
Could you please assign it to me?

sumaiyahibrahim avatar Jul 09 '25 13:07 sumaiyahibrahim

Hi! I'm new to open source and I’d love to work on this issue. Could you please assign it to me?

Hello. This issue is already assigned and there is an open PR for this. Suggest checking other issues. Thank you.

gorkem-bwl avatar Jul 09 '25 16:07 gorkem-bwl

Hi @gorkem-bwl, Can I work on this issue?

TheHarshitBansal avatar Aug 28 '25 19:08 TheHarshitBansal

Hi @gorkem-bwl, Can I work on this issue?

Thanks for the mesasge. I'm closing this one as the current ui is good enough to keep it as is.

gorkem-bwl avatar Aug 28 '25 22:08 gorkem-bwl