proxybroker2 icon indicating copy to clipboard operation
proxybroker2 copied to clipboard

Build mechanism

Open mcgr0g opened this issue 2 years ago • 7 comments

brought several improvements:

  • the ability to use dev containers on Windows VS Code
  • using a multi-stage build to reduce the size of the final image
  • more secure installation of poetry, as recommended by the developers
  • no pip usage
  • venv transport between images for painless and easy app installation in both debian-slim and alpine
  • custom build scripts revised and moved to makefile instructions
  • added commands to calculate image size
  • revised and moved commands for multiarch build. With context cleanup after completion.
  • added instructions for smoke testing the built image
  • significant details are reflected in the readme
  • following the OCI Image Format Specification

mcgr0g avatar Dec 21 '22 12:12 mcgr0g

hi @mcgr0g thanks for the big patch. I might need some time to review it. lol

@hms5232 @ziloka @afunTW @vincentinttsh would you like to take a look?

bluet avatar Dec 30 '22 17:12 bluet

I notice the develop environment setting set Poetry version 1.3.1, but project pipeline current is 1.1.4. I had made a PR to bump Poetry version in action test (see #115 ).

hms5232 avatar Dec 31 '22 07:12 hms5232

Personally, I prefer to keep the repo natural which means any setting for a specific IDE should be set in .gitignore. Let the developer focus on features and bugfix.

Or, from another viewpoint, aligning the development setting can boost the community's efficiency.

So far, seems the community go on the second option. As long as the testing passed, I am ok with that.

afunTW avatar Dec 31 '22 07:12 afunTW

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Dec 31 '22 09:12 sonarqubecloud[bot]

I have same thought as afunTW

vincentinttsh avatar Jan 04 '23 01:01 vincentinttsh

aligning the development setting can boost the community's efficiency.

I agree

ziloka avatar Feb 12 '23 23:02 ziloka

However after digging through python a bit more (I'm not an experienced python developer).

I found it that devcontainers are a bit heavy, and requires developers to install docker.

A easier solution is to create a virtual environment via poetry

poetry env use python

However I do agree using devcontainers give all developers a easier reproducible environment.

ziloka avatar Feb 13 '23 18:02 ziloka