tiled icon indicating copy to clipboard operation
tiled copied to clipboard

Should we rename the `FullText` query to just `Text`?

Open danielballan opened this issue 1 year ago • 3 comments

I think FullText is both verbose and a bit technical; maybe just plain Text would be better.

I also anticipate adding FuzzyText in the near future, with @Kezzsim's TypeSense work, and we wouldn't want FuzzyFullText....

danielballan avatar Jan 30 '24 15:01 danielballan

I think FullText conveys more authoritatively than Text that all of the metadata is being queried.

As far as FuzzyFullText and variants go, maybe an import alias is the right tradeoff for CLI usage?

import FuzzyFullText as Fuzzy

padraic-shafer avatar Jan 30 '24 21:01 padraic-shafer

...or maybe Search and FuzzySearch are both simple and well understood?

padraic-shafer avatar Jan 31 '24 12:01 padraic-shafer

You make a decent point about FullText. I worry about Search being too generic, as illustrated by the usage:

c.search(Search(...))

danielballan avatar Jan 31 '24 14:01 danielballan