tiled icon indicating copy to clipboard operation
tiled copied to clipboard

API key usage should bypass requirement of client.login()

Open matthewcarbone opened this issue 3 years ago • 3 comments

@danielballan @kleinhenz It would be really nice to not have to run e.g.

client = from_uri("https://aimm.lbl.gov/api")
client.login()  # <--- this

in order to access the private databases when my API key is already set. Any way to do this?

Originally opened here: https://github.com/AI-multimodal/aimmdb/issues/18.

matthewcarbone avatar Aug 15 '22 17:08 matthewcarbone

Thanks for the report. Will fix this and other login inconsistencies as part of #296 . Let’s leave this open to be sure we remember to test this case.

danielballan avatar Aug 16 '22 18:08 danielballan

Awesome, thank you, Dan! 👍

matthewcarbone avatar Aug 16 '22 20:08 matthewcarbone

@danielballan Unless I'm mistaken this appears to now be fixed! (independent of #296?)

CLIENT = from_uri("https://aimm.lbl.gov/api")
CLIENT.login()
# ...
# RuntimeError: API key authentication is being used.

And I am able to access the "private" data without using my ORCID id login, as intended. Thank you! This saves me much annoyance 👍

matthewcarbone avatar Aug 24 '22 13:08 matthewcarbone