ophyd icon indicating copy to clipboard operation
ophyd copied to clipboard

other areadetector file plugins need warmup() method

Open prjemian opened this issue 6 years ago • 3 comments

A warmup() method was implemented for the HDF5 plugin: https://github.com/bluesky/ophyd/blob/19269911c64594ca85e27c01dd0bfd86122b8400/ophyd/areadetector/plugins.py#L889-L903

As noted in https://github.com/bluesky/ophyd/issues/598#issuecomment-420327292 (merged in #599), other file-saving plugins need this capability, too. We've encountered this a couple times at APS (thanks to @KedoKudo for reporting this) with a TIFF plugin and also with a custom file-saving plugin. Should be the existing warmup() method move to the FilePlugin class?

prjemian avatar Sep 09 '19 16:09 prjemian

There has to be a better way to do this.

tacaswell avatar Sep 10 '19 02:09 tacaswell

Does anyone have time to find one? If not, I think we should move forward with this as a stop gap.

danielballan avatar Sep 17 '19 14:09 danielballan

I think the warmup() method should check the port flow map (if there is one) to make sure that it can actually get an image from the camera plugin. There could be situations where the file plugin is pointing to another processing plugin, which happen to be disconnected from the camera.

KedoKudo avatar Sep 17 '19 15:09 KedoKudo