ophyd icon indicating copy to clipboard operation
ophyd copied to clipboard

ENH: move the recursive collect_asset_docs up to Device

Open tacaswell opened this issue 2 years ago • 4 comments

While talking to @jklynch about how asset document collection works I noted that the recursive fallback was implemented in the AreaDetector related classes. As part of a push to refactor and (hopefully) simplify how we manage external resources it would be good to pull the recursive discovery and accumulation up to the Device level.

tacaswell avatar Apr 11 '22 20:04 tacaswell

This looks very sensible :+1:

Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures?

ZLLentz avatar May 10 '22 18:05 ZLLentz

This looks very sensible :+1:

Functionally, there's a small change here of only checking kind='normal'- could that be related to some of the area detector test failures?

ZLLentz avatar May 10 '22 18:05 ZLLentz

rebased and tweaked the test a bit.

It makes sense that collect asset docs and read should hit the same children.

tacaswell avatar May 10 '22 21:05 tacaswell

Yup, this is super broken and I have no idea why :(

I assume multiple inheritance is involved....

tacaswell avatar May 11 '22 01:05 tacaswell