databroker icon indicating copy to clipboard operation
databroker copied to clipboard

Remove unused `resource_roundtrip()` from test suite?

Open padraic-shafer opened this issue 10 months ago • 2 comments

This is not a test, and the function is not called anywhere. This dead code should probably be removed. Or could someone clarify what functionality is intended to be tested here?

https://github.com/bluesky/databroker/blob/23071d5cca95955e0dcd65e258afd13463fe2f99/databroker/tests/test_broker.py#L1124-L1138

padraic-shafer avatar Apr 14 '24 22:04 padraic-shafer

It came in via a915611cbde03ddc7120cf7d423ea2ad616af40c so I think it should have been named test_resource_roundtrip 🤦🏻 .

tacaswell avatar Apr 15 '24 19:04 tacaswell

and what I think this is testing is that the documents that come out of databroker can go back into databroker.

tacaswell avatar Apr 15 '24 19:04 tacaswell