bluesky icon indicating copy to clipboard operation
bluesky copied to clipboard

Best-effort callback - custom LiveTable

Open klauer opened this issue 3 years ago • 2 comments

Would it be reasonable to have a hook in the best effort callbacks to allow for customization of the classes used - such as a custom LiveTable subclass/implementation? If the answer is "yes", a similar hook for PeakStats, LivePlotPlusPeaks, etc. may follow.

Relevant source: https://github.com/bluesky/bluesky/blob/0a91b8b8a52509198ed5b884c208d58601424828/bluesky/callbacks/best_effort.py#L362

I admittedly don't know how this might fit into the overall future plans for BEC, which appear to be outlined here: https://github.com/bluesky/bluesky/issues/1271

klauer avatar Feb 10 '21 20:02 klauer

Bottom line: I'd merge a PR adding hooks if you need them, but I'd be interested to know how close bluesky-widgets is to meeting your use case(s). It is much more amenable to this kind of customization.

Best-effort callback is on the cusp of deprecation, so I'm inclined to avoid adding to its maintenance complexity if we can avoid it. I have added a comment to the issue you linked: https://github.com/bluesky/bluesky/issues/1271#issuecomment-779373922

danielballan avatar Feb 15 '21 17:02 danielballan

Would like to learn more about "bec on cusp of deprecation". From open discussions with @prjemian @mrakitin @gfabbris and others it seems that bec for hklpy presents some complications given how bec, LivePlot and LiveTable are all inter-related.

Is there a document describing bec.peaks replacement or a fork we can have a look at? Then maybe we can make a new issue for Bluesky that holistically deals with these complications in a forward looking manner.

ambarb avatar Jun 18 '21 03:06 ambarb