social-app icon indicating copy to clipboard operation
social-app copied to clipboard

Screen reader tells me I have "unread" notifications in mobile app, even when I don't

Open hs4man21 opened this issue 1 year ago • 1 comments

Describe the bug The notifications tab in the bottom menu is always telling me I have "Unread" notifications when using a screen reader. I opened the tab and scrolled through a number of the recent notifications (none of which were new), but when I left and came back to the tab my screen reader continued telling me "Unread."

See the video demo below. (Turn on audio to hear VoiceOver read the contents aloud.)

To Reproduce

Steps to reproduce the behavior:

  1. Use an iPhone (although I believe Android devices have this same issue when using their screen reader, TalkBack).
  2. Turn on the VoiceOver screen reader in your iPhone's accessibility settings.
  3. Open the Bluesky app.
  4. Tap the notifications tab when you have no new notifications, and notice that "unread" is still stated by the screen reader.

Expected behavior

I only hear "Unread" when I actually have new/unread notifications.

Screenshots

https://github.com/bluesky-social/social-app/assets/38192823/57d6fe84-da75-470c-becf-71aef2b7a1f9

Details

  • Platform: iPhone XR, iOS 16.4.1, using VoiceOver screen reader
  • Platform version: MacOS: Ventura 13.1, Chrome: 112.0.5615.137
  • App version: 1.28

hs4man21 avatar May 17 '23 05:05 hs4man21

I can take this. The issue is that getUnreadCountLabel returns an empty string if the value is 0, which impacts the corresponding hint.

renahlee avatar May 17 '23 05:05 renahlee