Improve usability of search on web

[haileyok]

Don't forget to revert TODO REVERT THESE CHANGES

Why

• Confusing naming of query, which really is queryTerm
• Inconsistent behavior on what the "X"/clear input button does compared to other websites/apps
• No browser history when navigating back through subsequent searches
• Extreme, ultra, incredible jank on web search input

How

Confusing naming

Pretty obvious from the diff, but I just renamed query to queryTerm here. query sounds more like it should be the result of a useQuery() hook, but it was just a string.

More to come...

[render[bot]]

Your Render PR Server URL is https://social-app-pr-3663.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cok23q0cmk4c7396qu40.

[github-actions[bot]]

Old size	New size	Diff
6.45 MB	6.43 MB	-17.12 KB (-0.26%)

---

[surfdude29]

If I visit a link for a search (e.g. https://social-app-pr-3663.onrender.com/search?q=cats ), Back shows up instead of Cancel, when there is no history and tapping it doesn't do anything.

This is in Safari on iPadOS 16.6.

[surfdude29]

Sorry to jump in here again as I can see you two are both working hard on this, I wanted to give you a heads up that the user experience in Safari on iPad isn't great if you select the search bar after scrolling down the results a bit, the keyboard appearing causes the entire UI to move up:

https://github.com/bluesky-social/social-app/assets/149612116/24cf449e-f342-4640-a1e5-5454ec0498cf

[gaearon]

@surfdude29 should be fixed, thanks.

[gaearon]

Also included:

• Fix iOS keyboard jump
• Reuse previous results while typing
• Instantly show profile shell on autocomplete navigation
• Put last clicked recent search at the top

[surfdude29]

@surfdude29 should be fixed, thanks.

Confirmed fixed for me on main.bsky.dev, thanks for these great search improvements @haileyok and @gaearon! 🙏