social-app icon indicating copy to clipboard operation
social-app copied to clipboard

German translation updated

Open snackpackwayne opened this issue 1 year ago • 4 comments

German translation updated.

EDIT: Paul Frazee here, hope you'll forgive the heist @snackpackwayne and thank you for this contribution. Going to reprint my comment below:

We've given up on the agency and are looking for a long-term replacement, but in the meantime we're going to do the following:

  • Keep pulling in feedback with this PR.
  • In a seperate PR, we're going to temporarily remove the german translation so that we're not pressed for time.

Bear in mind: this is a difficult thing for us to adjudicate because we don't speak german. We struggle to distinguish between suggestions and the reason we use agencies is to help us make the judgment calls. We just need a better agency.

snackpackwayne avatar Dec 27 '23 00:12 snackpackwayne

Thank you for your contributions @snackpackwayne and your cross-check @SharkyTheWhite

As @pfrazee mentioned, our agency should be getting back to us with an update soon. I'll pass these updates along to them.

ansh avatar Dec 28 '23 16:12 ansh

We've given up on the agency and are looking for a long-term replacement, but in the meantime we're going to do the following:

  1. Keep pulling in feedback with this PR.
  2. In a seperate PR, we're going to temporarily remove the german translation so that we're not pressed for time.

Bear in mind: this is a difficult thing for us to adjudicate because we don't speak german. We struggle to distinguish between suggestions and the reason we use agencies is to help us make the judgment calls. We just need a better agency.

pfrazee avatar Dec 28 '23 18:12 pfrazee

Great work! I have noted some suggestions, corrections, and additions here: https://github.com/snackpackwayne/social-app/pull/1/commits/b5e225eea0243c32eaa0a0583d2e46e384c4cd5b Please excuse that due to lack of time i am unable to review above comments or engage in the discussions.

CrispStrobe avatar Dec 29 '23 09:12 CrispStrobe

As contributions are accepted, please resolve the conversation for specific translations that are created @snackpackwayne

Thank you to everyone contributing to this translation!

ansh avatar Dec 29 '23 17:12 ansh

Okay sorry this took so long. I had to find time to do some manual review and compare against some outside confirmation. Didn't want to mess this one up again.

Thank you so much everyone. We'll be open to future PRs correcting language issues.

pfrazee avatar Jan 24 '24 04:01 pfrazee