social-app icon indicating copy to clipboard operation
social-app copied to clipboard

Dark mode on application startup

Open maisondasilva opened this issue 1 year ago • 17 comments

It would be nice to have an image with a darker background for those who use dark mode activated, because at night when opening the application it displays a bright image!

Imagem do WhatsApp de 2023-12-24 à(s) 11 21 11_c3856e46

maisondasilva avatar Dec 24 '23 14:12 maisondasilva

we'll have to see if that's possible. the splash is registered with the operating system and we may not be able to control it

pfrazee avatar Dec 27 '23 17:12 pfrazee

We can do this via the ios.splash.dark flag in iOS and its equivalent in Android

https://docs.expo.dev/versions/latest/config/app

@pfrazee Im happy to take this on. Will be fun!

ansh avatar Dec 30 '23 05:12 ansh

@ansh go for it

pfrazee avatar Jan 02 '24 19:01 pfrazee

Closed by https://github.com/bluesky-social/social-app/pull/2448

pfrazee avatar Jan 09 '24 19:01 pfrazee

There's still a full white screen before the splash image loads. I'm not seeing splash.dark changed in that PR

benharri avatar Jan 19 '24 19:01 benharri

I think this issue should be reopened. This post by @mukuuji.bsky.social demonstrates why:

bafkreidmvtj6xguczgxc6l3esds7aekk6gai2epxr7v2mz2hirebue45ru

To be slightly less tongue in cheek, for me as an Android user in dark mode, what I see after tapping the app icon is:

  1. Dark blue screen with blue/white app icon
  2. brief fade to completely white screen
  3. night sky with stars
  4. white butterfly appears
  5. butterfly zooms to full white screen
  6. fade to black dark mode of app.

So that's dark, full brightness, dark, full brightness, dark. It's actually quite unpleasant and I now tend to look away until the app is fully loaded. :(

scottdotweb avatar Feb 16 '24 16:02 scottdotweb

Update here, we've tweaked this again, and the butterfly is now a deep, almost-black blue. Should prevent blinding users. Will be included in next release, pending any further changes 👍

I don't think we've seen # 2 before, I'll note that and investigate. Thanks for the details on that!

estrattonbailey avatar Feb 16 '24 19:02 estrattonbailey

Thank you! I've got a screen recording of the app starting up if you need a demo.

scottdotweb avatar Feb 16 '24 19:02 scottdotweb

Oh that would be awesome if you don't mind uploading here 🙏

estrattonbailey avatar Feb 16 '24 19:02 estrattonbailey

https://github.com/bluesky-social/social-app/assets/7453240/38bf71d5-5bd3-44f8-965b-396cc5894305

here's a quick recording of both white flashes on cold startup. Android 14, pixel 6a

benharri avatar Feb 16 '24 20:02 benharri

Thanks Ben, that matched what I get. Android 14, Samsung Galaxy S23 Ultra.

scottdotweb avatar Feb 16 '24 20:02 scottdotweb

I see a white image before the butterfly on my Samsung

https://github.com/bluesky-social/social-app/assets/11423362/2b974a36-3313-491f-a142-60eef37e236a

maisondasilva avatar Feb 16 '24 20:02 maisondasilva

Thanks y'all! Really appreciate it. We'll have a closer look 👍

estrattonbailey avatar Feb 16 '24 21:02 estrattonbailey

@estrattonbailey I think this could be opened again?

maisondasilva avatar Feb 16 '24 21:02 maisondasilva

Oh sure! I'll keep myself assigned

estrattonbailey avatar Feb 16 '24 21:02 estrattonbailey

The latest update definitely helps by making the butterfly logo dark blue for dark mode users, but the white image described by @maisondasilva still exists.

parion avatar Mar 02 '24 22:03 parion

@parion Thanks Yes, it was very good but I can confirm that there is still a white image

maisondasilva avatar Mar 02 '24 23:03 maisondasilva

This should be fixed now from https://github.com/bluesky-social/social-app/pull/3105. Please feel free to ping if it isn't in the next (not the one today/tomorrow but the next) update!

Huge thanks to @edo-bari-ikutsu

haileyok avatar Mar 06 '24 18:03 haileyok