atproto icon indicating copy to clipboard operation
atproto copied to clipboard

Fix or disable pnpm warning "There are cyclic workspace dependencies"

Open trivikr opened this issue 3 months ago • 1 comments

Is your feature request related to a problem? Please describe.

Running make deps shows the following warning

 WARN  There are cyclic workspace dependencies: /Users/trivikram/workspace/atproto/packages/bsky, /Users/trivikram/workspace/atproto/packages/pds

This happens as the two packages are dependent on each other:

  • bsky has pds as a devDependency: https://github.com/bluesky-social/atproto/blob/c34426fc55e8b9f28d9b1d64eab081985d1b47b5/packages/bsky/package.json#L68
  • pds has bsky as a devDependency https://github.com/bluesky-social/atproto/blob/c34426fc55e8b9f28d9b1d64eab081985d1b47b5/packages/pds/package.json#L75

Describe the solution you'd like

Investigate if the cyclic dependency can be removed.

  • If yes, remove the cyclic dependency. This is recommended solution.
  • If no, set ignore-workspace-cycles to true in .npmrc so that the warning is not shown.

trivikr avatar Nov 15 '24 02:11 trivikr