Deniz Mert Edincik

Results 424 comments of Deniz Mert Edincik

I would consider removing grpc tbh, this creates incentives to keep rest api in sync with grpc ones. AN and Client communication is better handled with REST for sure. (...

I am a bit biased too maybe, not that I trust you but tbh I think REST will become less and less capable.

thank you for fixing this @davidwoood

@janezpodhostnik can you merge this one, I don't have permission

@turbolent related to this, can we add to Cadence Marshal/UnMarshal to/from struct? Like maybe with annotations like json?

@peterargue can you have a look? I want to be 100% sure what I did is correct before requesting a review.

those are fixed on another PR closing.

Doesn't this lose information about ordering? Let's say it is an event signature from past.

> @bluesign when would the order be required to know? Like I mentioned in my last comment, code that relies on the order is brittle anyways and should probably be...

I should have been more clear in my comment, I think order still has importance but ignoring that my main issue here is, if we have data in 2 versions...