Deniz Mert Edincik

Results 435 comments of Deniz Mert Edincik

I understand the concerns, and to be honest, I don't have too hard an opinion on this feature too. We can maybe drop this PR. My only concern was every...

@sideninja can you assist me here a bit, I am lost in git :( edit: I had to do force push, but I think required with rebase.

> > Maybe for packs the correct behavior would be to have the NFT destroyed once opened. This could be done in the pack opening function. > > I agree...

nit: do we have plans to register licenses with spdx ? if so it would be nice to use existing `License` struct, instead of strings in the array.

looks pretty good to me; but I have an idea; curious about what you think @joshuahannan Now we have NFTLicense ( seems like this will be only used for NLP...

actually not much benefit just making API a bit smaller. if we make spdx compatible later, we can just put spdx identifier, these views can be generated from that automatically...

I am thinking action will direct wallet to a FLIX, but I didn't think all details. It can help with adoption of FLIX too.

@joshuahannan it will just reference a FLIX; if wallet supports FLIX, it will get the transaction and ask user to fill the parameters if any and ask user to confirm.

> Are we far enough along with FLIX that we can make this now? I haven't been paying much attention to FLIX, so I don't know if it is all...

I feel borrowChildNFT should be on another interface, common usage is not having child NFT afaik. But also as this will be deprecated soon, it is not that big of...