Deniz Mert Edincik

Results 457 comments of Deniz Mert Edincik

very nice proposal, first time seeing FLIP here? what is the etiquette on commenting on FLIPS? Do we comment here?

If there will be rate limits, blacklists, and transaction verification, etc will be needed anyway, do you really need the API_KEY there? If we remove API_KEY, this removes the need...

I would go with script, something like: ```cadence pub fun main(): String { var networkCodeWords = { "MAINNET": UInt64(0x0), "TESTNET": UInt64(0x6834ba37b3980209), "EMULATOR": UInt64(0x1cb159857af02018) } for network in networkCodeWords.keys{ if getAccount(Address(UInt64(0xe467b9dd11fa00df)...

Those are network codewords, by xoring with 0xe467b9dd11fa00df you get the account at index 1. which is Service Account This depends on FVM behavior, though I don’t think it will...

There is also simple network addressing. ( which is not covered here ) used in playground as 0x1 0x2 etc

Also, this ones work. ``` pre { ((royaltyReceiver == nil) == (royaltyPercent == nil)) (royaltyPercent == nil ) } pre { (royaltyReceiver == nil) == (royaltyPercent == nil) royaltyPercent ==...

@turbolent, for example NFTView has CollectionData which has a function typed field. https://github.com/onflow/flow-nft/blob/9877dccbd884e06bbd754a4f693b7169dd6dd62b/contracts/MetadataViews.cdc#L514 Also references and some more types are not exportable, would be nice to make them exportable (...

Actually in script context it makes sense. But still try/catch is ugly, maybe something like: `DontPanic((():T)):(():T?)` in big friendly letters. So calling `getIDs()` safely will be: ```cadence var getIDsSafe =...

I made a very similar comment before @psiemens, but your implementation looks even better. Maybe even better can be using some helper functions (instead of import syntax), instead of `import...