piranha icon indicating copy to clipboard operation
piranha copied to clipboard

error: expected unqualified-id ::mpfr_set(m_value, other.m_value, default_rnd);

Open yurivict opened this issue 3 years ago • 7 comments

The python binding fails to build:

In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:751:11: error: expected unqualified-id
        ::mpfr_set(m_value, other.m_value, default_rnd);
          ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:811:11: error: expected unqualified-id
        ::mpfr_set(m_value, other.m_value, default_rnd);
          ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
In file included from /wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/core.cpp:64:
/wrkdirs/usr/ports/math/py-piranha/work-py38/piranha-0.11/pyranha/../src/real.hpp:856:15: error: expected unqualified-id
            ::mpfr_set(m_value, other.m_value, default_rnd);
              ^
/usr/local/include/mpfr.h:882:3: note: expanded from macro 'mpfr_set'
  __extension__ ({                              \
  ^
3 errors generated.

Version: 0.11 clang-11 FreeBSD 13

yurivict avatar Aug 31 '21 01:08 yurivict

@bluescarni This still fails.

Log: http://beefy15.nyi.freebsd.org/data/130i386-default/3446f8e94650/logs/py38-piranha-0.11_7.log (IPv6 URL)

yurivict avatar Oct 05 '21 16:10 yurivict

@bluescarni

Hi Francesco,

Could you please fix this?

Thank you, Yuri

yurivict avatar Oct 22 '21 00:10 yurivict

@yurivict Hi Yuri, I can't speak for Francesco but I worked with those libraries since its predecessor and I don't expect anybody changing anything in it. It is software that hasn't seen any changes for more than three years and it is rather outdated. v0.11 seems to have been a specific fix for gcc and I am even not sure which mp++ version is needed. I also doubt that the python binding was ever completely implemented and meanwhile everything should be Python 3 anyways. Depending on what you want do with it doesn't have all the features implemented that its predecessor possessed related to celestial mechanics. The lack of documentation points also at the fact that it is not a released version. Your choice here is probably to implement any changes you need by yourself, which doesn't look to be to difficult in this case. The next step could also be obake as successor of piranha. But I think this probably still has some missing functionality and I don't think that there is a python binding currently existing.

Cheers Hartmuth

7ofNine avatar Oct 25 '21 14:10 7ofNine

@bluescarni This is still an issue. Could you please take a look?

yurivict avatar Feb 10 '22 10:02 yurivict

@yurivict sorry for the delayed reply. As @7ofNine says, piranha development is dormant since a while. There is a successor project called obake:

https://github.com/bluescarni/obake

but it does not have all the features in piranha and development is slow there because these days I am focusing more on software projects (such as heyoka) more directly related to my research work.

I'll try to take a look at these issues the next few days (which I suspect are similar to the ones you reported for mp++), but can't promise on an ETA.

bluescarni avatar Feb 10 '22 10:02 bluescarni

@bluescarni, @yurivict Hi Francesco, Yuri I have a version of piranha that is updated to a modern version of mp++ in my repository. But there is no guarantee that it works with anything else than >VS2019 and C++20 and on my machine. There has been no compilations/tests done under anything else but a Windows environment . This also means the CMAKE files might be not correctly working for anything else but the above situation. But of course you may use it as a starter or as it is. There are also intermediate versions that could be better suited as a starter. You' ll find it here

7ofNine avatar Feb 10 '22 16:02 7ofNine

https://github.com/7ofNine/piranha-1

7ofNine avatar Feb 10 '22 16:02 7ofNine